-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 GIT-2731: enable TokenRequest for ServiceAccount token generation #2733
🌱 GIT-2731: enable TokenRequest for ServiceAccount token generation #2733
Conversation
Welcome @harshanarayana! |
Hi @harshanarayana. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ee4b478
to
e07a05d
Compare
/ok-to-test |
e07a05d
to
1149e17
Compare
/retest |
🤦 Broken indentation causing test failure. Let me fix. |
1149e17
to
6965ce4
Compare
/test pull-kubebuilder-e2e-k8s-1-18-20 |
/retest |
/test pull-kubebuilder-e2e-k8s-1-19-16 |
6965ce4
to
9c8a1e8
Compare
/test pull-kubebuilder-e2e-k8s-1-19-16 |
NOTEhad to make a hacky change to the setup.sh to make it switch between the right kind config file based on versions. kind config for 1.18 and 1.19 are the same file. These two files introduce new Argument to the API Server to make sure the |
@harshanarayana: GitHub didn't allow me to request PR reviews from the following users: everettraven. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5a7d2e0
to
9d02513
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shows great 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks so much for the contribution @harshanarayana!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven, harshanarayana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9d02513
to
27e0d3a
Compare
/lgtm |
Closes #2731
This addresses #2723 (comment)
Move to using an explicit Token generated for the SA by invoking the
kubectl create token
command.